Check relocating node id when finding source for reshard recovery #137848
+12
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticsearchmachine
added
v9.3.0
serverless-linked
jxie-1
force-pushed
the
reshard_relocate_source
branch
2 times, most recently
from
ea848f2 to
fb03765
Compare
jxie-1
force-pushed
the
reshard_relocate_source
branch
from
fb03765 to
f7fea19
Compare
elasticsearchmachine
added
the
needs:triage
jxie-1
added
>non-issue
:Distributed Indexing/Distributed
Collaborator
|
Pinging @elastic/es-distributed-indexing (Team:Distributed Indexing) |
lkts
reviewed
Nov 14, 2025
| sourceShardRouting.relocatingNodeId() | ||
| ); | ||
| } | ||
| return sourceNode; |
Contributor
There was a problem hiding this comment.
Can we explicitly return null here and below? It's much easier to read.
Contributor
There was a problem hiding this comment.
can we exercise this with some deterministic test?
Contributor
Author
There was a problem hiding this comment.
Sounds good, will add
lkts
approved these changes
Nov 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check the relocating node id when finding the source for reshard split recovery. Not sure if we should default to
currentNodeIdifrelocatingNodeIdexists but the node is unknown